Skip to content

BLS12-381 Crypto Primitives#154

Merged
arhag merged 13 commits intoAntelopeIO:bls_integrationfrom
mschoenebeck:main
Jul 18, 2023
Merged

BLS12-381 Crypto Primitives#154
arhag merged 13 commits intoAntelopeIO:bls_integrationfrom
mschoenebeck:main

Conversation

@mschoenebeck
Copy link
Contributor

@mschoenebeck mschoenebeck commented Apr 22, 2023 •
edited
Loading

This is the corresponding cdt pull request to 1071 of leap. Enable the following types and host functions for smart contracts.

Added the following types to cdt:

capi_bls_scalar  = uint8_t data[32];
capi_bls_fp      = uint8_t data[48];
capi_bls_fp2     = uint8_t data[96];
capi_bls_g1      = uint8_t data[144];
capi_bls_g2      = uint8_t data[288];
capi_bls_gt      = uint8_t data[576];

Added the following host functions to cdt (according to https://eips.ethereum.org/EIPS/eip-2537):

bls_g1_add(capi_bls_g1 op1, capi_bls_g1 op2, capi_bls_g1 result);
bls_g2_add(capi_bls_g2 op1, capi_bls_g2 op2, capi_bls_g2 result);
bls_g1_mul(capi_bls_g1 point, capi_bls_scalar scalar, bls_g1 result);
bls_g2_mul(capi_bls_g2 point, capi_bls_scalar scalar, bls_g2 result);
bls_g1_exp(capi_bls_g1[] points, capi_bls_scalar[] scalars, capi_bls_g1 result);
bls_g2_exp(capi_bls_g2[] points, capi_bls_scalar[] scalars, capi_bls_g2 result);
bls_pairing(capi_bls_g1[] g1_points, capi_bls_g2[] g2_points, capi_bls_gt result);
bls_g1_map(capi_bls_fp e, capi_bls_g1 result);
bls_g2_map(capi_bls_fp2 e, capi_bls_g2 result);
bls_fp_mod(std::array<uint8_t, 64> s, capi_bls_fp result);

Check out mschoenebeck/aggsigtest for a sample contract using those new host functions.

arhag
arhag reviewed Jun 6, 2023
View reviewed changes
@arhag arhag mentioned this pull request Jun 22, 2023
Closed
dimas1185
dimas1185 suggested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@dimas1185 dimas1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add integration tests.
need to do the following:
add test contract to the tests/unit/test_contracts that calls every bls function
add this test to the 'tests/integration/contracts.hpp.in'
add integration test to the 'tests/integration' that is using this contract to check that all actions work properly

dimas1185
dimas1185 reviewed Jun 29, 2023
View reviewed changes
libraries/eosiolib/core/eosio/crypto_bls_ext.hpp Outdated
}
}

int32_t bls_g1_add(const uint8_t* op1, const uint8_t* op2, uint8_t* res)
Copy link
Contributor

@dimas1185 dimas1185 Jun 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about something like this? that way you can enforce structure size:

using some_type = uint8_t[144];
    int32_t bls_g1_add(const some_type& op1, const some_type& op2, some_type& res)

Copy link
Contributor Author

@mschoenebeck mschoenebeck Jun 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added bls types to enforce correct operand sizes in: mschoenebeck@9d1424d

Edit: Updated https://github.com/mschoenebeck/aggsigtest/blob/main/aggsigtest.cpp as well.

@dimas1185 dimas1185 mentioned this pull request Jun 29, 2023
Closed
@mschoenebeck
Copy link
Contributor Author

mschoenebeck commented Jun 30, 2023

Added integration tests for all bls primitives in: mschoenebeck@7a6dfcb

@spoonincode
Copy link
Contributor

spoonincode commented Jul 1, 2023

The integration tests are not passing because the leap-dev.deb being used is from 4.0, which of course will not have support for the new bls host functions,

cdt/.github/workflows/build.yaml

Lines 70 to 80 in 3f701e2

- name: Download leap-dev.deb (Ubuntu 20 only)
if: matrix.platform == 'ubuntu20'
uses: AntelopeIO/asset-artifact-download-action@v2
with:
owner: AntelopeIO
repo: leap
file: 'leap-dev.*(x86_64|amd64).deb'
target: 4.0
artifact-name: leap-dev-ubuntu20-amd64
container-package: experimental-binaries
token: ${{github.token}}

If we'd like to see the tests pass here (and continue to pass post merge), we need to switch the leap-dev.deb over to one from leap's BLS PR. Sadly since it's a fork, referencing it by branch won't work, but I'm pretty sure using

   target: 90071617799738820350538f632ca5d5fd54e5e8

will work (this is the head of AntelopeIO/leap#1071 at the moment)

Once AntelopeIO/leap#1071 is merged in to leap's main, the above will need to become

   target: main

until 5.0 is cut, at which point it can then be changed to

   target: 5

@arhag arhag changed the base branch from main to bls_integration July 18, 2023 18:15
arhag
arhag approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@arhag arhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me. There are some small tweaks the ENF will do including getting the CI to fully pass. But we are good as it is to merge this into the bls_integraton branch.

@arhag arhag merged commit b540790 into AntelopeIO:bls_integration Jul 18, 2023
@arhag arhag mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@arhag arhag arhag approved these changes

@dimas1185 dimas1185 dimas1185 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Team Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mschoenebeck @spoonincode @arhag @dimas1185