Merged
Conversation
ScottBailey
reviewed
Apr 12, 2023
Contributor
There was a problem hiding this comment.
As always, I'd prefer these were built rather than stored in version control. Acceptable for now.
ScottBailey
reviewed
Apr 12, 2023
docs/man/cdt-cpp.1.md
Outdated
| title: CDT-CPP | ||
| section: 1 | ||
| header: User Manual | ||
| footer: cdt-cpp |
Contributor
There was a problem hiding this comment.
I think it's more consistent with other projects to use our organization here.
Suggested change
| footer: cdt-cpp | |
| footer: AntelopeIO |
ScottBailey
reviewed
Apr 12, 2023
docs/man/cdt-cpp.1.md
Outdated
Comment on lines
+17
to
+18
| **cdt-cpp** Is a C++ compiler which converts C++ code of the smart contracts to WebAssemply binary code for | ||
| execution in a virtual machine of Antelope block chains |
Contributor
There was a problem hiding this comment.
Suggested change
| **cdt-cpp** Is a C++ compiler which converts C++ code of the smart contracts to WebAssemply binary code for | |
| execution in a virtual machine of Antelope block chains | |
| **cdt-cpp** Is a C++ compiler which converts C++ smart contract code to WebAssemply for | |
| execution in Antelope block chain virtual machines |
ScottBailey
reviewed
Apr 12, 2023
docs/man/cdt-cpp.1.md
Outdated
| date: April 08, 2023 | ||
| --- | ||
| # NAME | ||
| cdt-cpp - Eosio C++ to WebAssembly compiler |
Contributor
There was a problem hiding this comment.
I think this would be better?
Suggested change
| cdt-cpp - Eosio C++ to WebAssembly compiler | |
| cdt-cpp - Antelope smart contract C++ to WebAssembly compiler |
ScottBailey
reviewed
Apr 12, 2023
ScottBailey
reviewed
Apr 12, 2023
ScottBailey
reviewed
Apr 12, 2023
docs/man/cdt-cpp.1.md
Outdated
|
|
||
| **`--allow-names`** | ||
|
|
||
| Allows name section to be created |
Contributor
There was a problem hiding this comment.
Suggested change
| Allows name section to be created | |
| Allow creation of name section |
ScottBailey
reviewed
Apr 12, 2023
ScottBailey
reviewed
Apr 12, 2023
ScottBailey
suggested changes
Apr 12, 2023
Contributor
ScottBailey
left a comment
There was a problem hiding this comment.
Please see comments. I've suggested some grammatical changes.
Contributor
Author
Thanks I made all changes you proposed. |
mikelik
reviewed
Apr 13, 2023
mikelik
approved these changes
Apr 13, 2023
Contributor
|
#143 addresses comments. |
ScottBailey
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a man page for cdt-cpp for issue #121
API Changes
Documentation Additions