Fix blks2cited_txt crash for document-based citations#101
Merged
Conversation
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/claudette/pull/101 |
Contributor
|
Thanks! |
Contributor
|
Ah FYI @erikgaas this caused docs deployment to break because you have a mixed cell with both an import, and other code. This doesn't work in nbdev. I'll fix it now. |
Contributor
Author
Ah darn sorry about that. Thanks for fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100
_cite()assumed web search citations (which have.url), but document citations have.document_titleinstead.This change uses
getattr(cit, 'url', None) or cit.document_titleto handle both cases.