Compatibility support for Deluxe Journal#525
Merged
drewhoener merged 1 commit intoAnnosz:masterfrom May 17, 2024
Merged
Conversation
…e DayTimeMoneyBox
Author
|
This is the most straightforward foot-in-the-door implementation, but I'm open to feedback on how you'd like this handled. I can definitely understand if having my mod's UniqueID hardcoded in the mod entry is off-putting. An alternative would be to expose this as some kind of API that my mod could control. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds compatibility support for the Deluxe Journal mod. The journal/quest log button becomes a permanent feature and covers up the UI Info Suite icons (when they shift over after all quests are completed).
Rather than doing something silly, like adding an invisible dummy quest (lots of issues will spawn from this), it would make more sense to check if Deluxe Journal was loaded on the UI Info Suite-side.
Deluxe Journal Nexus page for reference: https://www.nexusmods.com/stardewvalley/mods/11436.
And the GitHub repo: https://github.com/MolsonCAD/DeluxeJournal.