Skip to content

update zh.json#443

Merged
drewhoener merged 1 commit intoAnnosz:masterfrom
mc-kaishixiaxue:master
Mar 25, 2024
Merged

update zh.json#443
drewhoener merged 1 commit intoAnnosz:masterfrom
mc-kaishixiaxue:master

Conversation

@mc-kaishixiaxue
Copy link

@mc-kaishixiaxue mc-kaishixiaxue commented Mar 25, 2024

How about using "_comment+number": "xxx" fields instead of //xxx as json comments?

@drewhoener
Copy link
Collaborator

Thank you for the PR!
I've thought about it, but I'm against adding unrelated keys to the translation files.
Although comments in JSON is technically invalid, it doesn't affect parsing from the game (thankfully)

@drewhoener drewhoener merged commit 997ad02 into Annosz:master Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants