chore: migrate all .java files to kotlin and deps/build cleanup#986
Merged
Conversation
696d779 to
35f3f2a
Compare
39ea186 to
d775753
Compare
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
d775753 to
677eacf
Compare
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 5 minor |
| CodeStyle | 95 minor |
🟢 Metrics 3455 complexity · 542 duplication
Metric Results Complexity 3455 Duplication 542
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Replace the unresolvable com.github.nguyenhoanglam:ProgressLayout:master-SNAPSHOT dependency with a local com.mxt.anitrend.widget.ProgressLayout backed by a ProgressLayoutState enum. This removes the build failure caused by the dead SNAPSHOT artifact. Also restores missing resources lost during migration: - color/grey and color/grey_light legacy aliases - dimen/spacing_medium and dimen/spacing_small aliases - string/try_again alias - AppTheme style alias for manifest - drawable/bg_button.xml Fixes test compilation: - Escape Hamcrest matcher with backticks in Kotlin test files - Use MediaStatusValues.filterNotNull() for null-safe iteration - Use .orEmpty() on nullable groupBy fields
a597fd5 to
5ed286f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completes the Java-to-Kotlin migration and performs dependency/build system cleanup.
Changes
notCompatibleWithConfigurationCache()workaroundVerification
:app:assembleAppDebug— BUILD SUCCESSFUL:app:testAppDebugUnitTest— 57/57 tests passing, 0 failures--warning-mode all— No Gradle DSL deprecation warnings (only internal AGP warnings not actionable in our scripts)Remaining known issues
PrepareTaskstores aDefaultProjectreference that is incompatible with configuration cache (third-party plugin limitation)