Skip to content

ci: disable submit_prod lane in Fastfile#921

Merged
wax911 merged 1 commit into
developfrom
ci/disable-re-upload-to-promote-beta-build
Sep 24, 2025
Merged

ci: disable submit_prod lane in Fastfile#921
wax911 merged 1 commit into
developfrom
ci/disable-re-upload-to-promote-beta-build

Conversation

@wax911

@wax911 wax911 commented Aug 23, 2025

Copy link
Copy Markdown
Member

AniTrend Pull Request

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure you've done the following:

  • You have followed our contributing guidelines
  • Double checked that your branch is based on develop and targets develop (where applicable)
  • Pull request has tests (if applicable)
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved

Description

Once the beta build is submitted it is published. The idea of the submit_prod lane was to promote the beta build to production automatically but leave it in awaiting review. however this doesn't seem to work as expected so we'll just leave it as is

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (Improves existing functionality)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

Once the beta build is submitted it is published. The idea of the `submit_prod` lane was to promote the beta build to production automatically but leave it in awaiting review. however this doesn't seem to work as expected so we'll just leave it as is
Copilot AI review requested due to automatic review settings August 23, 2025 19:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the submit_prod lane in the Fastfile by commenting it out. The lane was intended to automatically promote beta builds to production while keeping them in draft status, but it wasn't working as expected and was causing builds to be published immediately instead.

  • Commented out the entire submit_prod lane definition to prevent unintended automatic publishing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@wax911 wax911 merged commit 40bca91 into develop Sep 24, 2025
9 checks passed
@wax911 wax911 deleted the ci/disable-re-upload-to-promote-beta-build branch September 24, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants