ci: sanity checks for fastlane#920
Merged
Merged
Conversation
…oads to GitHub Release always run
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements CI/CD sanity checks for fastlane by adding changelog validation and build improvements. The changes ensure that changelog files comply with Google Play Store's 500-character limit and enhance the build process with version extraction and artifact handling.
- Added automated changelog validation script to check 500-character limits
- Integrated version code/name extraction and passing to fastlane
- Enhanced artifact upload with conditional execution and error resilience
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/scripts/validate-changelogs.sh |
New validation script that checks changelog files against 500-character limit |
.github/scripts/setup-hooks.sh |
New script to set up pre-commit hooks for changelog validation |
.github/workflows/android-unit-test.yaml |
Added changelog validation step to unit test workflow |
.github/workflows/android-build.yaml |
Enhanced with version extraction, changelog validation, and improved artifact handling |
fastlane/Fastfile |
Added version_code parameter from environment variable |
.github/instructions/copilot-instructions.md |
Updated documentation with 500-character changelog limit requirement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3987806 to
6901543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AniTrend Pull Request
Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.
Before opening a pull request, please ensure you've done the following:
developand targetsdevelop(where applicable)Types of changes
IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.