Implemented Search According to Issue/Feature Requests#459
Merged
Andrews54757 merged 7 commits intoAndrews54757:mainfrom Dec 19, 2025
Merged
Implemented Search According to Issue/Feature Requests#459Andrews54757 merged 7 commits intoAndrews54757:mainfrom
Andrews54757 merged 7 commits intoAndrews54757:mainfrom
Conversation
Owner
|
Thanks for the PR! I've made the following changes:
Other modifications that I plan to do before merging:
If you want to do these, let me know! I will work on the rest in a week or so. |
Contributor
Author
|
I'm wrapping up University finals at the moment and then traveling shortly after, so the absolute soonest I'd be able to work on it is this weekend. I'll let you know how my timetable looks come then, hopefully I'll be able to take a crack at it! |
Owner
|
Enjoy the holidays! You don't have to do it if you don't want to, I can do it while also doing other refactoring work. It won't be much of a hassle for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: THERE ARE SOME CHANGES PERTAINING TO 1.3.71 THAT NEED TO BE RETAINED DUE TO ME DEVELOPING ON 1.3.70!
Dependencies Added: Fuse.JS (build time; minified JS in ./chrome/external), c8, AVA, codehawk-cli (static, npm packages only)
Hi Andrew! I just finished up my work building out the search feature on FastStream that I discussed a bit ago!
Notably, I merged hotkey/general options search into one search bar to reduce UI clutter, but I'd be happy to change UI specifics if needed!
Also, you'll see some additional libraries used for testing/QA purposes, and I'd be happy to make a branch/PR without them if that's more convenient for you. I used these specifically for the requirements within my report, but if they don't work well with the rest of your project, you won't hurt my feelings if you don't want them there!
Finally, if this implementation isn't up to your standards, or isn't a priority to integrate right now, no worries! It's not a grading criterion on my report to actually have the code merged into the existing codebase. Only merge my code if YOU think it works well for FastStream.
Thank you again for the wonderful opportunity to contribute to your project, and I hope that things go well for FastStream's future!