Add support for Svelte.js #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically just duplicated Vue configs
Owner
|
I'm not very familiar with Svelte, but I can see that it's similar to Vue in expecting script and style tags and HTML in one file. So I can see how it would work. I'm happy to include it. That said, what do you think about directly including the vue.js support file instead? So, instead of that code, this should work the same way: runtime ftplugin/vue/splitjoin.vimThe benefit is if any more Vue support is added, or if the callbacks are reordered to fix a bug, Svelte should work the same way. The drawback is that if we ever want to add Svelte-specific support, we'd have to go back to copy-pasting the code, but then we'd be in the same position anyway. What do you think? |
Contributor
Author
|
Yep, makes a lot of sense. Tested it, works, made a commit. |
Owner
|
Thanks, I'll go ahead and merge then 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just duplicated the Vue.js configs. Seems to work.