gk: loosen verification of gateway RT entries#630
Merged
AltraMayor merged 2 commits intomasterfrom Feb 16, 2023
Merged
Conversation
The routing table (RT) has been requiring gateway addresses not to be included in the prefix of gateway and grantor RT entries. This commit removes this requirement for gateway entries but maintains it for grantor entries. The motivation is to support default routes. Without this commit, default routes are denied with log entries similar to the ones below: DYC/9: check_gateway_prefix(0.0.0.0/0): gateway address is in prefix, so gateway is not a neighbor DYC/9: check_gateway_prefix(::/0): gateway address is in prefix, so gateway is not a neighbor
When the default IPv6 route is present, lookup_fe_from_lpm() forwards multicast and link-local IPv6 packets according to the default route instead of passing these packets to other functional blocks. This behavior breaks the ND implementation in the LLS block. This commit filters out multicast and link-local IPv6 packets in extract_packet_info(), so other functional blocks always get these packets.
Owner
Author
|
This pull request is happily running in production. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The routing table (RT) has been requiring gateway addresses not to be included in the prefix of gateway and grantor RT entries. This commit removes this requirement for gateway entries but maintains it for grantor entries.
The motivation is to support default routes.
Without this commit, default routes are denied with log entries similar to the ones below: