Skip to content

gk: loosen verification of gateway RT entries#630

Merged
AltraMayor merged 2 commits intomasterfrom
rtcheck
Feb 16, 2023
Merged

gk: loosen verification of gateway RT entries#630
AltraMayor merged 2 commits intomasterfrom
rtcheck

Conversation

@AltraMayor
Copy link
Owner

The routing table (RT) has been requiring gateway addresses not to be included in the prefix of gateway and grantor RT entries. This commit removes this requirement for gateway entries but maintains it for grantor entries.

The motivation is to support default routes.
Without this commit, default routes are denied with log entries similar to the ones below:

DYC/9: check_gateway_prefix(0.0.0.0/0): gateway address is in prefix, so gateway is not a neighbor
DYC/9: check_gateway_prefix(::/0): gateway address is in prefix, so gateway is not a neighbor

The routing table (RT) has been requiring gateway addresses not
to be included in the prefix of gateway and grantor RT entries.
This commit removes this requirement for gateway entries but
maintains it for grantor entries.

The motivation is to support default routes.
Without this commit, default routes are denied with log entries
similar to the ones below:

DYC/9: check_gateway_prefix(0.0.0.0/0): gateway address is in prefix, so gateway is not a neighbor
DYC/9: check_gateway_prefix(::/0): gateway address is in prefix, so gateway is not a neighbor
@AltraMayor AltraMayor added this to the Version 1.1 milestone Feb 14, 2023
@AltraMayor AltraMayor marked this pull request as ready for review February 15, 2023 00:41
When the default IPv6 route is present, lookup_fe_from_lpm()
forwards multicast and link-local IPv6 packets according to
the default route instead of passing these packets to
other functional blocks.  This behavior breaks
the ND implementation in the LLS block.

This commit filters out multicast and link-local IPv6 packets
in extract_packet_info(), so other functional blocks always get
these packets.
@AltraMayor
Copy link
Owner Author

This pull request is happily running in production. :)

@AltraMayor AltraMayor merged commit 84b069a into master Feb 16, 2023
@AltraMayor AltraMayor deleted the rtcheck branch February 16, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant