gatekeeper: support variable sizes of RSS hash keys#622
Merged
AltraMayor merged 6 commits intomasterfrom Oct 31, 2022
Merged
Conversation
46b8e19 to
1fe422a
Compare
The original code assumes all RSS hash keys are 10 * 4 = 40 bytes. While this assumption has held well through the years, recent NICs have keys that are 13 * 4 = 52 bytes long. This commit enables front and back interfaces to have different RSS hash keys of different lengths. However, if an interface is bonded, all the keys of the ports must have the same length. Otherwise, there would not be a way to find the RSS hash of a packet in software since there would be multiple values depending on where the packet arrived at the server.
When randomize_rss_key() was first written, the system call getrandom(2) had no wrapper. This commit replaces syscall(2) with getrandom(2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code assumes all RSS hash keys are 10 * 4 = 40 bytes. While this assumption has held well through the years, recent NICs have keys that are 13 * 4 = 52 bytes long. The length of RSS hash keys is always a multiple of 4 (i.e.
sizeof(uint32_t).This pull request enables front and back interfaces to have different RSS hash keys of different lengths. However, if an interface is
bonded, all the keys of the ports must have the same length. Otherwise, there would not be a way to find the RSS hash of
a packet in software since there would be multiple values depending on where the packet arrived at the server.