Merged
Conversation
The original get_empty_fib_id() prioritizes having all fib entries close together. This strategy is too slow for large routing tables. Having a speedy get_empty_fib_id() is critical to quickly populate the routing table when Gatekeeper boots up. To compare performance, a production routing table with 891094 prefixes was loaded via the Dynamic Configuration block. With the original get_empty_fib_id(), the load took 26 minutes and 10 seconds. With the speedy get_empty_fib_id(), the same load took 4 minutes and 26 seconds. That is almost 6 times faster!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original
get_empty_fib_id()prioritizes having all fib entries close together. This strategy is too slow for large routing tables. Having a speedyget_empty_fib_id()is critical to quickly populate the routing table when Gatekeeper boots up.To compare performance, a production routing table with 891094 prefixes was loaded via the Dynamic Configuration block. With the original
get_empty_fib_id(), the loading took 26 minutes and 10 seconds. With the speedyget_empty_fib_id(), the same load took 4 minutes and 26 seconds. That is almost 6 times faster!