Merged
Conversation
DPDK's commit d5df2ae0428a147b80bbb65d623f88f75d28b226 corrected the checksum of TCP by not turning a zero checksum into 0xFFFF as it is done for UDP. That fix also corrects the ICMPv6 checksum used in Gatekeeper, but nd_pkt_valid() was relying on the return being 0xFFFF to test that the checksum was correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DPDK's commit d5df2ae0428a147b80bbb65d623f88f75d28b226 corrected the checksum of TCP by not turning a zero checksum into
0xFFFFas it is done for UDP. That fix also corrects the ICMPv6 checksum used in Gatekeeper, butnd_pkt_valid()was relying on the return being0xFFFFto test that the checksum was correct.