lua: review Lua libraries and examples#561
Merged
AltraMayor merged 4 commits intov1.1-devfrom Jun 3, 2022
Merged
Conversation
The struct in_addrd and struct in6_addr were being defined in lua/gatekeeper/dylib.lua and lua/gatekeeper/policylib, so a Lua script that included both libraries would raise the error "attempt to redefine 'in_addr'". This error was first seen in script lua/examples/example_gt_lpm_params_request.lua.
This patch makes set_log_level_per_block() return the number of instances affected by the change. This information is useful to check that the function worked. Without this patch, the script lua/examples/example_of_dynamic_config_request.lua would fail with the following output: ./gkctl ../lua/examples/example_of_dynamic_config_request.lua [string "message"]:48: attempt to compare nil with number
The functions dylib.print_fib_dump_entry(), dylib.print_neighbor_dump_entry(), and dylib.print_lls_dump_entry() have changed a while ago, but example_of_dynamic_config_request.lua had not been updated to reflect those changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.