Gatekeeper: optimize logging for production#527
Merged
AltraMayor merged 2 commits intomasterfrom Sep 1, 2021
Merged
Conversation
GK blocks typically run at log level NOTICE in production in order to log traffic information. So this patch reduces the priority of two log entries that do not add much in production, are logged often, and are unavoidable. These log entries are as follows: `GATEKEEPER GK: Prefix lookup did not find existing neighbor FIB on back interface, as expected` This log entry and its respective for the front interface come often as routing daemons are always making adjustments to the FIB. Both log entries were at log level NOTICE, and are now INFO.
Gatekeeper servers have to tolerate unwanted traffic at some vantage points. And the following log entry can be excessive and unavoidable: `GATEKEEPER LLS: front interface should not be seeing a packet with EtherType 0x8847` Since LLS blocks typically run at WARNING level in production, this patch changed the log level of this log entry from ERR to NOTICE. As a side note, the EtherType 0x8847 corresonds to MPLS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request reduces log in production by lowering the priority of some log entries that do not add much in production,
are logged often, and are unavoidable.