Merged
Conversation
This patch scopes a couple variables of list_ipv4_fib_entries() and list_ipv6_fib_entries() in deeper code blocks.
While the value of fib_id has no meaning outside of Gatekeeper, it is useful to write Lua scripts for the dynamic configuration block to test the correctness of the FIB. The added script gkctl/scripts/check_fibs.lua searches for duplicate values of fib_id; what should not happen under normal conditions.
Owner
Author
|
Tested in production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first two patches tighten up the code in
gk/fib.c, whereas the third patch adds the FIB IDs of the FIB entries to the iterators available to the dynamic configuration block.