Skip to content

gk: remove useless log entry#520

Merged
AltraMayor merged 1 commit intomasterfrom
gk_fib_log
Aug 11, 2021
Merged

gk: remove useless log entry#520
AltraMayor merged 1 commit intomasterfrom
gk_fib_log

Conversation

@AltraMayor
Copy link
Owner

The log entry below doesn't have an equivalent for IPv6 and it's ONLY logged when

  1. The number of IPv4 packets that rte_eth_rx_burst() returns is not multiple of 4; and
  2. The destination of the last packets on the array of returned packets is not on the LPM table of IPv4.

The multiple of 4 emerges from the use of rte_lpm_lookupx4(). So there might be 1, 2, or 3 last packets that could trigger
the log entry.

Moreover, adding the log entry to all other conditions (i.e. multiple of 4 and IPv6) is not helpful because all packets whose destinations are not in the FIB are passed to the filter subsystem to be directed to another block. And the filter system already has a log entry for unmatched packets.

THIS PATCH REMOVES THE FOLLOWING LOG ENTRY:
GATEKEEPER GK: process_pkts_front could not find FIB entry when processing incoming IPv4 flow

The log entry below doesn't have an equivalent for IPv6 and
it's ONLY logged when
1. The number of IPv4 packets that rte_eth_rx_burst() returns
   is not multiple of 4; and
2. The destination of the last packets on the array of
   returned packets is not on the LPM table of IPv4.

The multiple of 4 emerges from the use of rte_lpm_lookupx4().
So there might be 1, 2, or 3 last packets that could trigger
the log entry.

Moreover, adding the log entry to all other conditions
(i.e. multiple of 4 and IPv6) is not helpful because
all packets whose destinations are not in the FIB are passed to
the filter subsystem to be directed to another block.
And the filter system already has a log entry for
unmatched packets.

THIS PATCH REMOVES THE FOLLOWING LOG ENTRY:
GATEKEEPER GK: process_pkts_front could not find FIB entry
when processing incoming IPv4 flow
@AltraMayor AltraMayor added the Operational demand This issue would make Gatekeeper safer and/or cheaper to operate label Aug 11, 2021
@AltraMayor AltraMayor added this to the First deployment milestone Aug 11, 2021
@AltraMayor
Copy link
Owner Author

Tested on the XIA1 server.

@AltraMayor AltraMayor merged commit a54f668 into master Aug 11, 2021
@AltraMayor AltraMayor deleted the gk_fib_log branch August 11, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Operational demand This issue would make Gatekeeper safer and/or cheaper to operate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant