cps: push not-handled ICMP packets to KNI interfaces#511
Merged
AltraMayor merged 1 commit intomasterfrom Jul 28, 2021
Merged
Conversation
Gatekeeper only handles a couple of ICMP packets, and drops all the rest. This patch forwards the rest of the ICMP packet to the KNI interfaces, so the kernel can use them. This enhances diagnosis and IPv6 compatibility. As a bonus, this patch simplifies Gatekeeper's code since Gatekeeper no longer has to deal with ping and other ICMP cases.
Owner
Author
|
Tested in production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gatekeeper only handles a couple of ICMP packets, and drops all the rest. This patch forwards the rest of the ICMP packet to
the KNI interfaces, so the kernel can use them. This enhances diagnosis and IPv6 compatibility.
As a bonus, this patch simplifies Gatekeeper's code since Gatekeeper no longer has to deal with ping and other ICMP cases.