Skip to content

cps: improve handling of RTNetlink edit requests#495

Merged
AltraMayor merged 4 commits intomasterfrom
rtnl_edit
Jun 10, 2021
Merged

cps: improve handling of RTNetlink edit requests#495
AltraMayor merged 4 commits intomasterfrom
rtnl_edit

Conversation

@AltraMayor
Copy link
Owner

This pull request:

  1. adds support to the RTNetlink flags NLM_F_EXCL, NLM_F_REPLACE, and NLM_F_CREATE for RTM_NEWROUTE requests;
  2. Removes the requirement of interface information for RTM_NEWROUTE requests;
  3. Protects grantor entries from being edited by routing daemons.

lpm_is_rule_present() and lpm6_is_rule_present() replace
rte_lpm_is_rule_present() and rte_lpm6_is_rule_present(),
respectively.

The motivation for lpm_is_rule_present() and lpm6_is_rule_present()
is to abstract when an IP address must be converted to
the CPU endianness.  This is similar to what lpm_lookup_ipv4() and
lpm_lookup_ipv6() do.
@AltraMayor AltraMayor added the Operational demand This issue would make Gatekeeper safer and/or cheaper to operate label Jun 10, 2021
@AltraMayor AltraMayor added this to the First deployment milestone Jun 10, 2021
This patch adds support to the RTNetlink flags NLM_F_EXCL,
NLM_F_REPLACE, and NLM_F_CREATE.  Routing daemons need these flags.
@AltraMayor
Copy link
Owner Author

Tested in production.

@AltraMayor AltraMayor merged commit 09482dd into master Jun 10, 2021
@AltraMayor AltraMayor deleted the rtnl_edit branch June 10, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Operational demand This issue would make Gatekeeper safer and/or cheaper to operate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant