Merged
Conversation
mengxiang0811
approved these changes
May 24, 2021
Collaborator
mengxiang0811
left a comment
There was a problem hiding this comment.
Patch lib: increase log level for wrong VLAN tag report is ready for merge.
mengxiang0811
approved these changes
May 24, 2021
Collaborator
mengxiang0811
left a comment
There was a problem hiding this comment.
Patch cps: review log messages of rtnetlink for KNI is ready for merge.
Log entries similar to the one below can be overwhelming in production due to loose filters: GATEKEEPER: l2: front interface received an ARP packet with an incorrect VLAN tag (0xd06 but should be 0x60d)
This patch adds more information to the log messages and simplify the code by reorganizing where IPv4 and IPv6 addresses are converted to strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following patches improve some log entries according to the feedback we've received from a production deployment.