log_ratelimit: allow all startup logs#469
Merged
AltraMayor merged 1 commit intoAltraMayor:masterfrom Apr 23, 2021
Merged
Conversation
AltraMayor
requested changes
Apr 22, 2021
Owner
AltraMayor
left a comment
There was a problem hiding this comment.
log_ratelimit: allow all startup logs
c816355 to
e1f6ba3
Compare
Collaborator
Author
|
Ready for another review. |
AltraMayor
requested changes
Apr 23, 2021
Owner
AltraMayor
left a comment
There was a problem hiding this comment.
log_ratelimit: allow all startup logs
Before the functional blocks launch (at the end of stage 3), they are all run on the master lcore (0). Therefore, the rate limit for lcore 0 is applied to all block initialization and the network initialization. In practice, lcore 0 is always assigned to the LLS block, since we initialize it first. Therefore, the LLS rate limit is applied to all startup logs. This patch adds a flag to the log ratelimiting library, which is only set when initialization is complete. Therefore, all startup logs will be captured.
e1f6ba3 to
c6c19c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the functional blocks launch (at the end of stage 3),
they are all run on the master lcore (0). Therefore, the rate
limit for lcore 0 is applied to all block initialization and
the network initialization.
In practice, lcore 0 is always assigned to the LLS block,
since we initialize it first. Therefore, the LLS rate limit
is applied to all startup logs.
This patch adds a flag to the log ratelimiting library,
which is only set when initialization is complete. Therefore,
all startup logs will be captured.