gkctl: implement connect wait timeout#467
Merged
AltraMayor merged 4 commits intoAltraMayor:masterfrom Apr 16, 2021
andrenth:gkctl-connect-wait
Merged
gkctl: implement connect wait timeout#467AltraMayor merged 4 commits intoAltraMayor:masterfrom andrenth:gkctl-connect-wait
AltraMayor merged 4 commits intoAltraMayor:masterfrom
andrenth:gkctl-connect-wait
Conversation
AltraMayor
requested changes
Apr 16, 2021
Owner
AltraMayor
left a comment
There was a problem hiding this comment.
gkctl: return 0 in case of success
AltraMayor
requested changes
Apr 16, 2021
Owner
AltraMayor
left a comment
There was a problem hiding this comment.
gkctl: wait for dynamic socket to be ready
This simplifies error checking when using gkctl in shell scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a connection timeout command-line option for
gkctl. This is useful when running this command right after starting gatekeeper (e.g. via a systemd post-start command). Since it takes a while for gatekeeper to be ready to listen for connections in the dynamic configuration socket, it would be otherwise necessary to run asleepcommand beforegkctlin the hopes that we have waited enough for the socket to be ready.The PR also includes a commit to change
gkctl's success return code to0, to ease handling errors in shell scripts, and trivial spacing fixes.