net: replace getlogin_r with getpwuid#458
Merged
AltraMayor merged 1 commit intoAltraMayor:masterfrom Mar 1, 2021
andrenth:replace-getlogin
Merged
net: replace getlogin_r with getpwuid#458AltraMayor merged 1 commit intoAltraMayor:masterfrom andrenth:replace-getlogin
AltraMayor merged 1 commit intoAltraMayor:masterfrom
andrenth:replace-getlogin
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getlogin_r()was used to obtain a user name to be used as the first argument for the subsequentinitgroups()call. However,getlogin_r()returns the user name of the logged in user which started Gatekeeper (that is, root), while the correct argument toinitgroups()is the name of the unprivileged user defined innet.lua.Furthermore,
getlogin_r()doesn't work when the process has no controlling terminal, as is the case for processes started from an init system such as systemd.