Skip to content

gatekeeper: add support for /31 (IPv4) and /127 (IPv6) subnet masks#456

Merged
AltraMayor merged 1 commit intoAltraMayor:masterfrom
mengxiang0811:host-prefix
Mar 26, 2021
Merged

gatekeeper: add support for /31 (IPv4) and /127 (IPv6) subnet masks#456
AltraMayor merged 1 commit intoAltraMayor:masterfrom
mengxiang0811:host-prefix

Conversation

@mengxiang0811
Copy link
Collaborator

@mengxiang0811 mengxiang0811 commented Feb 24, 2021 •
edited by AltraMayor
Loading

This pull request closes #444.

@AltraMayor AltraMayor added this to the First deployment milestone Feb 24, 2021
AltraMayor
AltraMayor requested changes Feb 25, 2021
View reviewed changes
Copy link
Owner

@AltraMayor AltraMayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatekeeper: add support for /31 (IPv4) and /127 (IPv6) subnet masks

This pull request needs to be rebased to make the compiling GitHub action work again due to a package change. More details can be found in the comment of the last commit of the repository.

AltraMayor
AltraMayor requested changes Feb 25, 2021
View reviewed changes
Copy link
Owner

@AltraMayor AltraMayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatekeeper: add support for /31 (IPv4) and /127 (IPv6) subnet masks

AltraMayor
AltraMayor requested changes Feb 25, 2021
View reviewed changes
Copy link
Owner

@AltraMayor AltraMayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatekeeper: add support for /31 (IPv4) and /127 (IPv6) subnet masks

@mengxiang0811
Copy link
Collaborator Author

mengxiang0811 commented Mar 1, 2021

This rebase is ready for another review.

AltraMayor
AltraMayor requested changes Mar 1, 2021
View reviewed changes
Copy link
Owner

@AltraMayor AltraMayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatekeeper: add support for /31 (IPv4) and /127 (IPv6) subnet masks

@mengxiang0811
Copy link
Collaborator Author

mengxiang0811 commented Mar 11, 2021

Ready for another review.

AltraMayor
AltraMayor requested changes Mar 11, 2021
View reviewed changes
Copy link
Owner

@AltraMayor AltraMayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatekeeper: add support for /31 (IPv4) and /127 (IPv6) subnet masks

@mengxiang0811 mengxiang0811 force-pushed the host-prefix branch 2 times, most recently from 4a7b444 to 6cf87c7 Compare March 15, 2021 07:51
@mengxiang0811
Copy link
Collaborator Author

mengxiang0811 commented Mar 15, 2021

Ready for another review.

AltraMayor
AltraMayor reviewed Mar 15, 2021
View reviewed changes
AltraMayor
AltraMayor requested changes Mar 15, 2021
View reviewed changes
Copy link
Owner

@AltraMayor AltraMayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatekeeper: add support for /31 (IPv4) and /127 (IPv6) subnet masks

AltraMayor
AltraMayor requested changes Mar 15, 2021
View reviewed changes
Copy link
Owner

@AltraMayor AltraMayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatekeeper: add support for /31 (IPv4) and /127 (IPv6) subnet masks

AltraMayor
AltraMayor requested changes Mar 15, 2021
View reviewed changes
Copy link
Owner

@AltraMayor AltraMayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatekeeper: add support for /31 (IPv4) and /127 (IPv6) subnet masks

@mengxiang0811
Copy link
Collaborator Author

mengxiang0811 commented Mar 24, 2021

Thanks @AltraMayor ! Ready for another review.

AltraMayor
AltraMayor requested changes Mar 24, 2021
View reviewed changes
Copy link
Owner

@AltraMayor AltraMayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatekeeper: add support for /31 (IPv4) and /127 (IPv6) subnet masks

@mengxiang0811
Copy link
Collaborator Author

mengxiang0811 commented Mar 26, 2021

Ready for another review.

@AltraMayor AltraMayor merged commit dc61d43 into AltraMayor:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltraMayor AltraMayor AltraMayor requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

First deployment

Development

Successfully merging this pull request may close these issues.

Gatekeeper should support /31 (IPv4) and /127 (IPv6) subnet masks

2 participants

@mengxiang0811 @AltraMayor