Skip to content

gatekeeper: update to the latest DPDK#293

Merged
AltraMayor merged 1 commit intoAltraMayor:masterfrom
mengxiang0811:dpdk-update
Jun 19, 2019
Merged

gatekeeper: update to the latest DPDK#293
AltraMayor merged 1 commit intoAltraMayor:masterfrom
mengxiang0811:dpdk-update

Conversation

@mengxiang0811
Copy link
Collaborator

This pull request closes #272

@AltraMayor
Copy link
Owner

To which branch in our DPDK repository is this pull request moving Gatekeeper? None of the branches "gatekeeper" and "gatekeeper2" seems to be what we talked about in our last Thursday meetup. This is critical because this pull request claims to close issue #272 and doesn't seem to do so.

It'd be nice to add a summary of the changes in the commit message. Example of items to add to this summary:

* Rename constant `ETHER_TYPE_IPv4` to `RTE_ETHER_TYPE_IPV4`
* Rename constant `ETHER_TYPE_IPv6` to `RTE_ETHER_TYPE_IPV6`
* Rename `struct arp_hdr` to `struct rte_arp_hdr`

This would quickly make someone like Cody aware of the changes between DPDK's versions. Instead of requiring taking a look into the patch to find that out.

@mengxiang0811
Copy link
Collaborator Author

This rebase is ready for review. Note that, the fix for the verifier is vulnerable to malicious code issue has not been addressed, although it's a small fix. I will track this issue.

@AltraMayor
Copy link
Owner

What about a way to compile DPDK with CONFIG_RTE_LIBRTE_BPF_ELF=y?

* Rename constant `ETHER_TYPE_IPv4` to `RTE_ETHER_TYPE_IPV4`
* Rename constant `ETHER_TYPE_IPv6` to `RTE_ETHER_TYPE_IPV6`
* Rename constant `ETHER_TYPE_ARP` to `RTE_ETHER_TYPE_ARP`
* Rename `struct arp_hdr` to `struct rte_arp_hdr`
* Rename ARP header related fields and opcode
* Rename constant `ETHER_ADDR_FMT_SIZE` to `RTE_ETHER_ADDR_FMT_SIZE`
* Rename `struct ether_hdr` to `struct rte_ether_hdr`
* Rename `struct ether_addr` to `struct rte_ether_addr`
* Rename struct ether_addr related function calls
* Rename `struct vlan_hdr` to `struct rte_vlan_hdr`
* Rename `struct ipv4_hdr` to `struct rte_ipv4_hdr`
* Rename `struct ipv6_hdr` to `struct rte_ipv6_hdr`
* Rename `struct tcp_hdr` to `struct rte_tcp_hdr`
* Rename `struct udp_hdr` to `struct rte_udp_hdr`
* Rename `struct icmp_hdr` to `struct rte_icmp_hdr`
@mengxiang0811
Copy link
Collaborator Author

The patch has been added back now.

@AltraMayor AltraMayor merged commit 834af43 into AltraMayor:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update DPDK to properly support BPF

2 participants