Skip to content

Support oci sync#112

Merged
hhyasdf merged 2 commits intoAliyunContainerService:masterfrom
lujiajing1126:master
Jun 27, 2023
Merged

Support oci sync#112
hhyasdf merged 2 commits intoAliyunContainerService:masterfrom
lujiajing1126:master

Conversation

@lujiajing1126
Copy link
Copy Markdown
Contributor

@lujiajing1126 lujiajing1126 commented Mar 2, 2023

Pull Request Description

Describe what this PR does / why we need it

This PR add support for OCI image specs

Does this pull request fix one issue?

Fixes #100

Describe how you did it

Describe how to verify it

Special notes for reviews

@lujiajing1126
support oci sync
13c3486 
Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
@lujiajing1126 lujiajing1126 mentioned this pull request Mar 2, 2023
Closed
@htlabc
Copy link
Copy Markdown

htlabc commented Mar 8, 2023

This PR add can't support for OCI image specs,when you push oci media type to harbor will get some error

@lujiajing1126
Copy link
Copy Markdown
Contributor Author

lujiajing1126 commented Mar 8, 2023

This PR add can't support for OCI image specs,when you push oci media type to harbor will get some error

Well, your destination must support OCI, for example, JFrog Artifactory. From the official Habor blog, https://goharbor.io/blog/harbor-2.0/, it starts to support OCI from 2.0.

Otherwise, you may have to transform from DockerImage to OCI image locally.

@hiddletian
Copy link
Copy Markdown

hiddletian commented Jun 19, 2023

The letest image syncer where can download，can slove application/vnd.oci.image.manifest.v1+json

@lujiajing1126
Copy link
Copy Markdown
Contributor Author

lujiajing1126 commented Jun 19, 2023

The letest image syncer where can download，can slove application/vnd.oci.image.manifest.v1+json

Not pretty catch your meaning. But if you want a working binary, you may clone my fork https://github.com/lujiajing1126/image-syncer and build on your server.

hhyasdf
hhyasdf approved these changes Jun 27, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hhyasdf hhyasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8a981fe) 53.96% compared to head (9a6f1ae) 53.96%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   53.96%   53.96%           
=======================================
  Files           1        1           
  Lines          63       63           
=======================================
  Hits           34       34           
  Misses         24       24           
  Partials        5        5
Flag Coverage Δ
unittests 53.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hhyasdf hhyasdf merged commit 7667168 into AliyunContainerService:master Jun 27, 2023
@hhyasdf hhyasdf mentioned this pull request Jun 27, 2023
Closed
@FeiYing9 FeiYing9 mentioned this pull request Oct 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hhyasdf hhyasdf hhyasdf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unsupported manifest type: application/vnd.oci.image.manifest.v1+json

5 participants

@lujiajing1126 @htlabc @hiddletian @codecov-commenter @hhyasdf