Skip to content

Navigation Bar#28

Merged
AlexFlipnote merged 14 commits intoAlexFlipnote:masterfrom
Snazzah:pr/nav-bar
Mar 26, 2020
Merged

Navigation Bar#28
AlexFlipnote merged 14 commits intoAlexFlipnote:masterfrom
Snazzah:pr/nav-bar

Conversation

@Snazzah
Copy link
Contributor

@Snazzah Snazzah commented Mar 25, 2020

preview

The navigation bar can be fixed and auto-collapses on resize.

Adds:

  • Navigation bar

Changes:

  • Moved the script tag to the bottom of the page to avoid page breaks
  • Changed docs to use navigation bars
  • Made check_arrow and check_nav_bar to be called on script initialization

@AlexFlipnote
Copy link
Owner

I would rather have a navbar that is both clickable and comes from the left side, something similar to this (aka. app menus)

Image

@Snazzah
Copy link
Contributor Author

Snazzah commented Mar 25, 2020

I could probably add that in as something like a "expandable sidebar". Would it be OK to add that in as a new thing or to replace nav-bars with that?

@AlexFlipnote
Copy link
Owner

Preferably replace.

@Snazzah
Copy link
Contributor Author

Snazzah commented Mar 25, 2020

Should the header also move with the rest of the page or stay?

@AlexFlipnote
Copy link
Owner

eh maybe don't move the page, kinda overkill now that I rethink it.
Just make the menu get dragged out like usual Android menus.

@Snazzah
Copy link
Contributor Author

Snazzah commented Mar 26, 2020

Redesigned it.

Normal Preview

preview

Fixed Preview

preview

@AlexFlipnote AlexFlipnote merged commit 57644ff into AlexFlipnote:master Mar 26, 2020
@Snazzah Snazzah deleted the pr/nav-bar branch March 26, 2020 13:40
@Snazzah Snazzah restored the pr/nav-bar branch March 26, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants