Skip to content

chore: Remove vllm device argument#183

Merged
mys007 merged 1 commit intomainfrom
remove-vllm-device
Feb 26, 2026
Merged

chore: Remove vllm device argument#183
mys007 merged 1 commit intomainfrom
remove-vllm-device

Conversation

@mys007
Copy link
Copy Markdown
Contributor

@mys007 mys007 commented Feb 25, 2026

PR Checklist

  • Use descriptive commit messages.
  • Provide tests for your changes.
  • Update any related documentation and include any relevant screenshots.
  • Check if changes need to be made to docs (README or any guides in /docs/).
  • Reflect the changes you made in the changelog.

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

The device argument is deprecated (vllm-project/vllm#18399) and it does not work with VLLM >= 0.9, in case anyone is using a dependency override. In principle one could also relax the dependency but this is out of score (testing-wise) of this PR...

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the hardware and config this has been tested on, as well as any relevant
additional information.

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

@mys007 mys007 marked this pull request as ready for review February 25, 2026 13:25
@mys007 mys007 merged commit 93b4f8a into main Feb 26, 2026
37 of 47 checks passed
@mys007 mys007 deleted the remove-vllm-device branch February 26, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants