Skip to content

fix custom_sub_filter#155

Merged
tatsumoto-ren merged 2 commits intoAjatt-Tools:masterfrom
j1g5awi:master
Feb 5, 2026
Merged

fix custom_sub_filter#155
tatsumoto-ren merged 2 commits intoAjatt-Tools:masterfrom
j1g5awi:master

Conversation

@j1g5awi
Copy link
Copy Markdown
Contributor

@j1g5awi j1g5awi commented Feb 3, 2026

pcall return bool, so custom_sub_filter will always be bool and cause error

@tatsumoto-ren
Copy link
Copy Markdown
Member

tatsumoto-ren commented Feb 4, 2026

This pcall was added to avoid the crash: 57643f2
So simply removing it will just return us back to the old problem.

We need to figure out why #151 causes mpvacious to crash.

At first glance, this might be why:

    if not ok then
        error(
                string.format(
                        "Failed to load module '%s' from '%s'. Error: %s",
                        module_name,
                        module_path,
                        tostring(loaded_module)
                )
        )
    end

@tatsumoto-ren
Copy link
Copy Markdown
Member

@NamelessAssassin any ideas how to fix?

@mosaic-roll
Copy link
Copy Markdown
Contributor

mosaic-roll commented Feb 5, 2026

@NamelessAssassin any ideas how to fix?

It works on my machine :<

Perhaps using mp.msg.error instead of error is better?

My OS is windows 11, is this related?

@tatsumoto-ren
Copy link
Copy Markdown
Member

If we use mp.msg.error instead of error, loaded_module should be assign to nil when the module fails to load

I think we could try that and see if this issue occurs again.

My OS is windows 11, is this related?

This is not related to the issue, but mpvacious does not recommend using any versions of Windows or macOS.

@tatsumoto-ren tatsumoto-ren merged commit fba205e into Ajatt-Tools:master Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants