fix custom_sub_filter#155
Merged
tatsumoto-ren merged 2 commits intoAjatt-Tools:masterfrom Feb 5, 2026
Merged
Conversation
Member
|
This pcall was added to avoid the crash: 57643f2 We need to figure out why #151 causes mpvacious to crash. At first glance, this might be why: if not ok then
error(
string.format(
"Failed to load module '%s' from '%s'. Error: %s",
module_name,
module_path,
tostring(loaded_module)
)
)
end |
Member
|
@NamelessAssassin any ideas how to fix? |
Contributor
It works on my machine :< Perhaps using My OS is windows 11, is this related? |
Member
I think we could try that and see if this issue occurs again.
This is not related to the issue, but mpvacious does not recommend using any versions of Windows or macOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pcall return bool, so custom_sub_filter will always be bool and cause error