Add support for ankiconnect api key#142
Conversation
|
Hello! Why would you need to add that to mpvacious? Apparently, Rikaitan already supports it, and it was added 3 years ago, but the purpose is unclear. |
ankiconnect.lua
Outdated
| local self = {} | ||
|
|
||
| self.execute = function(request, completion_fn) | ||
| if self.config.ankiconnect_api_key ~= '' then |
There was a problem hiding this comment.
should call is_empty() here.
I had to make this change for it to work*, given my current ankiconnect config 😅 As for why ankiconnect felt the need to add such an option, i'm not sure, but since it exists, it'd be nice to have feature parity and support it. Though admittedly it does not seem widely used, given that no one's asked for it yet 🤔 *unauthenticated requests are ignored if
Dug around for context, and found FooSoft/yomichan#2139 |
Hello there! AnkiConnect allows setting an api key for use in authenticating requests, which is also supported by rikaitan
This pr proposes to add support for it by way of adding an
ankiconnect_api_keyconfig option