Join sentence fields and separate joined fields by newline#136
Merged
tatsumoto-ren merged 4 commits intoAjatt-Tools:masterfrom Mar 31, 2025
Merged
Join sentence fields and separate joined fields by newline#136tatsumoto-ren merged 4 commits intoAjatt-Tools:masterfrom
tatsumoto-ren merged 4 commits intoAjatt-Tools:masterfrom
Conversation
helpers.lua
Outdated
Comment on lines
+280
to
+287
| this.match_substring = function(text, substring) | ||
| local escaped_substring = substring:gsub("([%W])", "%%%1") | ||
|
|
||
| return string.match(text, "^" .. escaped_substring .. "$") | ||
| or string.match(text, "^" .. escaped_substring .. "<br>") | ||
| or string.match(text, "<br>" .. escaped_substring .. "$") | ||
| or string.match(text, "<br>" .. escaped_substring .. "<br>") | ||
| end |
Member
There was a problem hiding this comment.
If you need to check if substring is a substring of text, it's probably easier to just call string.find()
return string.find(text, substring, 1, true) ~= nil -- use plain searches
Contributor
Author
There was a problem hiding this comment.
It is, but then you can get false positives. I think if you're joining foo bar and bar you should get foo bar<br>bar, not just foo bar.
Member
There was a problem hiding this comment.
I think the user can reformat the field any way they like, including inserting additional characters between subtitle lines. So I would only care about whether the substring is found or not.
Contributor
Author
There was a problem hiding this comment.
Okay, I'll remove the helper function then since it would only be one line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #134.
A few thoughts: