Skip to content

DO NOT MERGE test against some fork of endo#9201

Draft
erights wants to merge 1 commit intomasterfrom
markm-test-w-some-endo-fork
Draft

DO NOT MERGE test against some fork of endo#9201
erights wants to merge 1 commit intomasterfrom
markm-test-w-some-endo-fork

Conversation

@erights
Copy link
Copy Markdown
Member

@erights erights commented Apr 5, 2024

#endo-branch: markm-qp-nested-pattern-errors

closes: #XXXX
refs:

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

@erights erights self-assigned this Apr 5, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 5, 2024

⚠️ The sha of the head commit of this PR conflicts with #7937. Mergify cannot evaluate rules on this PR. ⚠️

@erights erights added the force:integration Force integration tests to run on PR label Apr 5, 2024
@erights erights force-pushed the markm-test-w-some-endo-fork branch 2 times, most recently from d029689 to 6a68857 Compare April 5, 2024 21:02
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 6a68857 to e1b1a19 Compare May 5, 2024 05:31
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented May 5, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: d04a19f
Status: ✅  Deploy successful!
Preview URL: https://7312911d.agoric-sdk.pages.dev
Branch Preview URL: https://markm-test-w-some-endo-fork.agoric-sdk.pages.dev

View logs

@erights erights force-pushed the markm-test-w-some-endo-fork branch from 5fbdd1b to 2e1471a Compare May 5, 2024 06:00
@erights erights changed the base branch from master to 1488-Endo-Passable May 5, 2024 06:01
@kriskowal
Copy link
Copy Markdown
Member

Seems to be down to some ts-expect-errrors that can now be removed.

Error: ../vats/src/vat-bank.js(347,5): error TS2578: Unused '@ts-expect-error' directive.
Error: ../vats/src/vat-bank.js(591,7): error TS2578: Unused '@ts-expect-error' directive.

};
};

// Gratuitous change so I can create an otherwise identical PR
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git commit -m 'Poke CI' --allow-empty creates a no-changes commit that will pump CI.

@turadg turadg force-pushed the 1488-Endo-Passable branch from b6dc0e1 to d4aaa74 Compare May 6, 2024 21:07
@erights erights force-pushed the markm-test-w-some-endo-fork branch 2 times, most recently from 1158cab to 575f79d Compare May 6, 2024 21:58
@turadg turadg force-pushed the 1488-Endo-Passable branch from d4aaa74 to 09c12d6 Compare May 7, 2024 17:14
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 575f79d to 08ff8aa Compare May 8, 2024 22:47
@erights erights changed the base branch from 1488-Endo-Passable to master May 8, 2024 22:47
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 08ff8aa to 9e18813 Compare May 9, 2024 00:26
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 9e18813 to 339a3ef Compare October 14, 2024 20:22
@erights erights force-pushed the markm-test-w-some-endo-fork branch 2 times, most recently from 3319e64 to 7cabc52 Compare January 3, 2025 20:50
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 7cabc52 to 407e282 Compare January 4, 2025 21:39
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 407e282 to 47ca514 Compare January 19, 2025 20:21
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 47ca514 to 0973650 Compare January 20, 2025 19:18
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 0973650 to 52bed17 Compare April 26, 2025 19:17
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 52bed17 to 7174399 Compare April 26, 2025 19:22
@erights erights removed the force:integration Force integration tests to run on PR label Apr 26, 2025
@erights erights force-pushed the markm-test-w-some-endo-fork branch 2 times, most recently from b754974 to 8a910cd Compare April 26, 2025 20:50
@erights erights force-pushed the markm-test-w-some-endo-fork branch 2 times, most recently from 5836eab to 8b3c809 Compare May 21, 2025 02:34
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 29b9b62 to 1a0528b Compare June 26, 2025 21:19
@kriskowal kriskowal added the force:integration Force integration tests to run on PR label Jun 26, 2025
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 1a0528b to d04a19f Compare June 26, 2025 22:54
@erights erights requested a review from Copilot September 16, 2025 08:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is a test PR that adds a gratuitous comment line to explore branch differences against a fork of endo. The change serves no functional purpose and is explicitly marked as not intended for merging.

  • Adds a single comment line acknowledging the gratuitous nature of the change

};
};

// Gratuitous change so I can create an otherwise identical PR
Copy link

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gratuitous comment should be removed as it serves no functional purpose and adds unnecessary noise to the codebase. Test changes should have clear intent and not include arbitrary modifications.

Suggested change
// Gratuitous change so I can create an otherwise identical PR

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

force:integration Force integration tests to run on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants