fix(vault): use singleton pattern for vaultManager#5650
Closed
fix(vault): use singleton pattern for vaultManager#5650
Conversation
Change the ephemeral state to scoped in the makeVaultManager function
Contributor
Chris-Hibbert
left a comment
There was a problem hiding this comment.
Hmm. That's definitely simpler, and closer to our usual JS style, but it seems further from the common pattern for our durable objects, so I'm not sure the simplicity is an advantage.
Member
|
Note to reviewers: Hide whitespace differences before reviewing the diffs. Bigger help here than usual. |
Chris-Hibbert
approved these changes
Jun 28, 2022
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #5622
Description
Implement ephemeral state by using singleton pattern
Security Considerations
TBD
Testing Considerations
TBD