Patch vega d3 fix fixme#2575
Merged
Merged
Conversation
FUDCo
approved these changes
Mar 4, 2021
dckc
approved these changes
Mar 4, 2021
dckc
left a comment
Member
There was a problem hiding this comment.
I think I understand this. But you might do well to stand by for reviews from others who are more confident.
michaelfig
requested changes
Mar 4, 2021
michaelfig
left a comment
Member
There was a problem hiding this comment.
LGTM, after the behaviour changes are fixed.
michaelfig
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found and patched where vega-util was overriding
Object.constructorby assignment.Fixing that uncovered same problem with d3-color. Same patch.
vega-util was also overriding two other frozen primordial properties by assignment,
hasOwnPropertiesandtoString. Patched both, althoughtoStringis a hopeless cause. But fixinghasOwnPropertiesmeans SES can stop enabling it, further reducing vscode debugger's object inspector noise.Fixes #2556
Fixes the FIXME kludge added to bin/runner at
https://github.com/Agoric/agoric-sdk/pull/2552/files/84f9ccf388e6aeb71b5aabb2a552e5ec36d4fa9f#r585869497
See
vega/vega#3075
endojs/endo#576