refactor(job): remove useless Start and Stop functions from AutoDeleteDepletedClientsJob #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new cron job that automatically deletes clients who have exhausted their traffic or whose subscription has expired. The feature is configurable via a new setting in the panel, allowing administrators to specify the number of days after depletion/expiration when a client should be removed.
- Change auto delete setting from minutes to days.
…eDepletedClientsJob The Start and Stop functions in AutoDeleteDepletedClientsJob were creating a new cron instance, which was redundant as the application already has a global cron scheduler. This commit removes these functions and their usage, and the job is now added to the main cron scheduler.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Start and Stop functions in AutoDeleteDepletedClientsJob were creating a new cron instance, which was redundant as the application already has a global cron scheduler. This commit removes these functions and their usage, and the job is now added to the main cron scheduler.