feat(adapters): add standalone embedder functions#66
Merged
Conversation
Add openaiEmbedder, geminiEmbedder, ollamaEmbedder, deepseekEmbedder, grokEmbedder, and kimiEmbedder to @agentskit/adapters. Each returns an EmbedFn (text → number[]) using raw fetch with no SDK dependencies. - Add EmbedFn type to @agentskit/core - Shared openaiCompatibleEmbedder factory for DeepSeek/Grok/Kimi - Model discovery on error: fetches available models from provider API - Verbose fallback error when model list fetch also fails - Contract tests + unit tests with msw for HTTP mocking Closes #10
The msw package was installed locally but not committed to package.json, causing CI to fail with "Cannot find package 'msw'" errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmbedFntype to@agentskit/coreas the shared embedding contract@agentskit/adapters:openaiEmbedder,geminiEmbedder,ollamaEmbedder,deepseekEmbedder,grokEmbedder,kimiEmbedderopenaiCompatibleEmbedderfactory powers DeepSeek/Grok/Kimi thin wrappersfetch— no SDK dependencies, consistent with existing chat adaptersTest plan
pnpm buildsucceeds across all packagespnpm --filter @agentskit/adapters lintpassespnpm --filter @agentskit/core lintpassesCloses #10