This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Update faraday dependency to support faraday 2.x#42
Merged
Bossa573 merged 2 commits intoAfterShip:masterfrom Dec 13, 2022
Merged
Update faraday dependency to support faraday 2.x#42Bossa573 merged 2 commits intoAfterShip:masterfrom
Bossa573 merged 2 commits intoAfterShip:masterfrom
Conversation
Since faraday 2.x, `faraday-middleware` has been deprecated (more info here: https://github.com/lostisland/faraday/blob/main/UPGRADING.md#faraday-middleware-deprecation) and it's no longer supported
Contributor
Author
Contributor
Author
|
@aftership-admin @renyuanz @Bossa573 @teddychan Hi! any chance you could have a look at this PR and review it? |
Contributor
Author
|
Hi @Beaelf ! I can see there's some recent activity in aftership-sdk-go but this SDK didn't get updates for a while. Is this SDK still actively maintained? It would be good to bring some of these dependencies up to date. |
Member
|
if this is a breaking change, a major version bump is required. |
Contributor
|
https://github.com/lostisland/faraday/blob/main/UPGRADING.md |
inverse
reviewed
Dec 12, 2022
liguangbo
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
New Faraday 2.x:
faraday-middlewarehas been deprecated and it's no longer supportedMinimum Ruby version
Note: While the Faraday interface has changed, this gem does not get affected by those changes. The Faraday middleware that this gem is using is now part of the core Faraday gem, so the gem does not need this dependency anymore.