This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Add compatibility for recent versions of Faraday#39
Merged
Bossa573 merged 1 commit intoAfterShip:masterfrom Feb 26, 2021
FraDim:patch-1
Merged
Add compatibility for recent versions of Faraday#39Bossa573 merged 1 commit intoAfterShip:masterfrom FraDim:patch-1
Bossa573 merged 1 commit intoAfterShip:masterfrom
FraDim:patch-1
Conversation
Allow the use of a Faraday version that supports ruby 2.3, while also allowing more recent versions of Faraday. This will increase repo compatibility and enable the users of this library to follow the suggestion of using its latest version.
Contributor
Author
|
My app uses Faraday v1.3.0 (the latest at the time of writing) but cannot use the latest version of the Aftership gem, because of the very tight Faraday version constraint. I think this will improve the situation that caused the revert of #35. @Bossa573 @renyuanz I haven't seen a way to run automated tests, so can you please check if this works for your supported Ruby versions? |
Member
|
@FraDim thank you for the PR, and we will merge this PR and release a new version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the use of a Faraday version that supports ruby 2.3, while also allowing more recent versions of Faraday.
This will increase repo compatibility and enable the users of this library to follow the suggestion of using its latest version.