Double width overflow support#51
Conversation
|
Thanks for your MR, that looks good to me! The pipeline fails, because you also need to update the call to tsm_screen_draw() in src/gtktsm/gtktsm-terminal.c ../src/gtktsm/gtktsm-terminal.c:1055:21: error: too few arguments to function ‘tsm_screen_draw’ Also This breaks backward compatibility (an old version of kmscon won't work with a new version of libtsm). |
I added double width support to Gtktsm, so this should be fixed now. |
|
@kdj0c @michael-oberpriller There is no need to break the ABI IMHO. I've figured out a way to emulate what most major terminals do (as shown in Aetf/kmscon#18). In fact, no changes are needed for libtsm. I will submit a PR shortly. |
|
@michael-oberpriller @kdj0c please see Aetf/kmscon#136. Hopefully one of you can find it useful to do proper implementation. |
|
These changes have been implemented in Aetf/kmscon#135. |
No description provided.