Notification method isSuccess() always returns true #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property "success" is evaluating wrongly.
Summary
When using JSON for Notifications, the decoded value for property $response["success"] may be a String.
Example for a failed response, { success: "false" }
The method Notification->isSuccess() compares that value with an array of [ true, "true" ] and this fails, because the string "false" is evaluating as true.
Suggestion:
in_array() should be using strict-type checking when comparing an unknown value with a real Boolean, because any String or any Number different than zero will otherwise evaluate as true.
Tested scenarios
Created a Standard notification Webhook in the Adyen Customer Area.
Configured my endpoint for JSON, HTTP Authentication and HMAC signature.
Then generated an AUTHORIZATION test notification, using the "Test configuration" button.