[ECP-9704] Implement new event processors and deprecate RECURRING_CONTRACT event #65
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @candemiralp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request adds support for several new Adyen webhook events, specifically the EXPIRE event and the suite of recurring token lifecycle events. It also deprecates the older RECURRING_CONTRACT event, guiding users towards the new tokenization webhook structure. New processor classes and payment states were introduced to handle these changes, along with updates to the processor factory and unit tests.
Highlights
- New Event Processors: Implemented new processors for the
EXPIREand token lifecycle webhook events (recurring.token.created,recurring.token.updated,recurring.token.disabled,recurring.token.alreadyExisting). - EXPIRE Event Handling: Added an
ExpireProcessorthat changes the payment state tocancelledfor pending payments that are not auto-captured. For other initial states or auto-captured payments, the state remains unchanged. - Token Lifecycle Event Handling: Introduced a
TokenLifecycleEventProcessorto handle the new recurring token events. This processor currently results in no state change. - RECURRING_CONTRACT Deprecation: The
RECURRING_CONTRACTevent constant and its corresponding processor have been marked as deprecated, encouraging the use of the new tokenization webhooks. - New Payment State: Added a new
STATE_PARTIALLY_PAIDconstant to thePaymentStatesclass. - Processor Factory Updates: Updated the
ProcessorFactoryto map the new event codes to their respective processor classes and added corresponding unit tests.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request effectively introduces new event processors for EXPIRE and several recurring.token.* events, while also deprecating the RECURRING_CONTRACT event as described. Additionally, a new payment state STATE_PARTIALLY_PAID has been added. The accompanying tests for the new processors cover their intended logic.
My review includes a couple of suggestions for the new ExpireProcessor.php aimed at improving the clarity of its PHPDoc and the conciseness of its process method logic. Overall, the changes are well-structured and align with the PR's objectives.
|
Summary
This PR implements processors for the following webhook events.
Besides providing these,
RECURRING_CONTRACTwebhook event has been deprecated in the favour of the new token lifecycle events.Tested scenarios