pspReference Null coalescing and String check #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing check to isTestNotification()
Contributor
Author
|
Perhaps we may assume there will always be a "pspReference", as I'm always getting one right now. |
peterojo
approved these changes
Aug 20, 2021
Morerice
approved these changes
Aug 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Null coalescing to "pspReference" response parameter. Added string check to isTestNotification()
Summary
The NotificationReceiver method validateHmac() crashes when the property 'pspReference' is missing on the $response array.
Somehow, this property was not always set for all my notifications.
The method isTestNotification() uses string comparison on this property to determine whether the notification is indeed a test.
But the function strtolower() does not accept null.
So if somehow the "pspReference" is missing from the response, this workflow generates a PHP error and crashes the process, which should otherwise be a valid notification.
Tested scenarios
Created a Standard notification Webhook in the Adyen Customer Area.
Configured my endpoint for JSON, HTTP Authentication and HMAC signature.
Then generated an AUTHORIZATION test notification, using the "Test configuration" button.