[PW-5725] Add support for missing event codes #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
peterojo
reviewed
Nov 30, 2021
peterojo
reviewed
Nov 30, 2021
|
SonarCloud Quality Gate failed. |
acampos1916
reviewed
Dec 6, 2021
acampos1916
reviewed
Dec 6, 2021
Contributor
|
For cases where the payment state doesn't change we can introduce a new method in protected function unchanged(string $event): string
{
$state = $this->initialState;
$this->log('info', 'Processed ' . $event . ' notification.', [
'eventCode' => $event,
'originalState' => $state,
'newState' => $state
]);
return $state;
} |
acampos1916
reviewed
Dec 8, 2021
acampos1916
reviewed
Dec 8, 2021
Contributor
Author
|
Nice suggestion @michaelpaul , As we discussed I added the |
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
michaelpaul
approved these changes
Dec 8, 2021
peterojo
reviewed
Dec 9, 2021
peterojo
reviewed
Dec 9, 2021
acampos1916
reviewed
Dec 9, 2021
peterojo
reviewed
Dec 10, 2021
peterojo
approved these changes
Dec 13, 2021
In case of modification.result cancel use the cancel processor but in case of refund use the refund processor
|
SonarCloud Quality Gate failed. |
michaelpaul
approved these changes
Dec 14, 2021
Morerice
approved these changes
Dec 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is about adding support for missing event codes. Each processor move the state or not based on the original state and the notification.
Tested scenarios
Extended the ProcessorFactory class
Fixed issue: