Update FSAF + fix handle local thread json parsing exception in another place#773
Merged
Merged
Conversation
…er place - Update FSAF to v1.0-alpha39 which has couple of fixes related to files listed in a directory and file containing more than one period at the end of it. - Local thread json parsing exception was not handled in all places where it could be called. Now it should be handled in all places and the error should be propagated down to the ThreadPresenter where we will show it instead of infinite spinner. - Use default external storage dir path when couldn't figure out where the initial position of SaveLocationController should be.
…shes sometimes with "root is already FileRoot" exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #714, #772 and couple of more fixes for #720 and more logs to fix this #638 issue (again) (I kinda have a hunch why this thing happens but need confirmation)