Couple of improvements to prevent crash log spam in the future:#745
Merged
Adamantcheese merged 1 commit intoFeb 27, 2020
Merged
Conversation
K1rakishou
commented
Feb 26, 2020
- Only store crash logs for 3 days.
- Add the time of crash to logs so the really old logs can be easily filtered out on the server side.
- Do not append the stack trace twice (most of the time we already have stack trace in the logcat logs).
- Only store crash logs for 3 days. - Add the time of crash to logs so it's can be easy to filter old logs on the server side. - Do not append the stack trace twice (most of the time we already have stack trace in the logcat logs).
Author
|
This needs to be merged ASAP. We also really need to do another hotfix release. We already have lots of fixes so there is no point in waiting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.