Dependencies and cleanup#680
Merged
Adamantcheese merged 3 commits intoFeb 22, 2020
Merged
Conversation
Owner
|
Actually migrating to RxJava 3 would go completely smoothly as we don't do anything particularly complicated. @K1rakishou your tests would need to be updated to account for this information (notably getEvents was removed), as you use it in almost every test: https://github.com/ReactiveX/RxJava/wiki/What%27s-different-in-3.0#test-support-methods |
Noooo. But I guess we can try switching to 3.0. There were some API changes so a little bit of refactoring is expected. I guess we could extract it into a separate task. |
|
Oh by the way
This may actually help with problems some people are experiencing with images refusing to start getting downloaded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oh boy it's that time again.
1st commit
2nd commit (Look over the changelogs to see if there's any new features you might want to use)
3rd commit