(#585) Possible fix for chunks directory not being created (+ update FSAF with couple more additional checks)#652
Conversation
All the code related to base directory change has been move into it's own delegate classes so that it doesn't take the whole space in MediaSettingController
- Update FSAF. Now when selecting a directory via ACTION_OPEN_DOCUMENT_TREE persistence permissions will be check as well (whether we have them or not). - Fix a bug where uri tree was forgotten right after we set them (this is one of possible causes of strange bugs where people couldn't access their base directory sometimes).
- Update FSAF to v1.0-alpha26 with more logs to figure out why it sometimes crashes with "Cannot append anything anymore root is FileRoot already". I wonder what's the path looks like in such case. - Do not use forgetOldSAFBaseDirectory because it was probably the cause of "Base directory is not registred" error. Apparently, if your new base directory is a child of the previous one, then when forgetting the previous one we also lose permissions to use the current one. So let's just not revoke any rights at all upon selecting a new base directory and see how it works.
Do not allow using any remote providers (google drive/dropbox/etc) as a base directory because they may not work correctly with ACTION_OPEN_DOCUMENT_TREE and persistable permissions
…ase directories use different providers (because it's buggy as hell and really hard to figure out whether they are the same directory or whether one directory is a parent of another (there is not API for that and custom implementation is full of hacks that often break)), so just let the user do this manually. - Make the paths in Move files/Delete files dialog more distinct so it's easier to see them. - Update FSAF to v1.0-alpha28 with a fix for isChildOfDirectory() not correctly determine whether one directory is a parent/child of the other directory.
…verything related to remote file providers in the settings' dialogs because we don't support them anymore
…annot be created when trying to do so via SaveLocationController.
|
Is this good to merge now? The previous PR before that massive git merge whatever it was was still marked as a WIP. Also do you just use git from the command line or do you use a different tool, out of curiosity. |
|
I've fucked up the previous one, apparently, by merging a wrong branch. I couldn't get rid of those commits by rebasing it so I decided to just nuke it and cherry pick everything into a new branch. I use Android Studio's tools. And yeah, it's ready. |
|
I forgot to mention it when I merged this, but maybe you want to try out a Git application that's specific to just source control; I use Sourcetree, but Git Kraken looks like the successor? Might alleviate some of those branch merge issues that you've had previously. |
|
I think I just need to be more careful when merging branches because I don't think it's the software issue. |
|
Eh, it's a suggestion. I find built-in IDE source control tends to be lacking and more prone to errors. Notably because I've wiped entire remote repositories using them before. |
|
Well maybe I could give it a try, one day. |
Closes #585
Maybe fixes #580, #629, #537
More logs for #579 and #638