(#568) New domain wth ssl https://kuroba.io:8443#599
Merged
Conversation
…textTraffic flag as is because Android won't allow to connect to it even though it redirects to https url. So we will have to wait couple of months before everyone has updated so we can safely remove that flag. Release builds should be able to update as they had already done - via GitHub, should be no issues here. Old dev clients should be able to update via the http flag. New client will be updated via new https url. Also checked reporting/crash reporting on dev - works fine. Release build will be able to send reports/crash report with the next update. For now they can't.
Author
|
|
Author
|
|
Author
|
Nevermind x2, I managed to implement support for both http and https and the same time. Based fucking Vert.x it was a really great idea to use it for backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #568
Change DEV_API_ENDPOINT to https://kuroba.io:8443 but leave usesCleartextTraffic flag as is because Android won't allow to connect to it even though it redirects to https url. So we will have to wait couple of months before everyone has updated so we can safely remove that flag.
Release builds should be able to update as they had already done - via GitHub, should be no issues here.
Old dev clients should be able to update via the http flag.
New clients will be updated via new https url.
Also checked reporting/crash reporting on dev - works fine.
Release builds will be able to send reports/crash report with the next update. For now they can't.