(#562) Fix a request not getting canceled when encountering a 404 response from the server#575
Merged
Merged
Conversation
…ponse from the server If we encounter an exception in ChunkPersister and the current state is Running, that's find, that just means that an exception other than CancellationException was thrown. So that means that we only need to do the canceling of the current request, pass the exception downstream and that's it. It will be handled by the downstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we encounter an exception in ChunkPersister and the current state is Running, that's find, that just means that an exception other than CancellationException was thrown. So that means that we only need to
do the canceling of the current request, pass the exception downstream and that's it. It will be handled by the downstream.
Closes #562